Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload/ipfs: Grab video format from the right place #164

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

victorges
Copy link
Member

I copied it from the export task where the asset spec is fully present, but during upload we
need to check the intermediate values like the result from catalyst itself or the local probing
(both on the assetSpec variable).

For that also moved the local probing to before the ipfs upload, or it still might've not been populated.

@victorges victorges requested a review from a team as a code owner March 6, 2023 13:53
Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorges victorges merged commit 9d09ecf into main Mar 9, 2023
@victorges victorges deleted the vg/fix/upload-ipfs branch March 9, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants