Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/upload: Allow asset IPFS metadata player template on creation #170

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

victorges
Copy link
Member

We had a legacy check on the export task to only allow assets with playback URLs to
use player NFT metadata. This was because our very first assets didn't even have an HLS
playlist and just provided MP4 URLs.

For new assets creation, the only other place where saveNFTMetadata is called, this is not
necessary tho, as we will always create an HLS playback URL for the asset, or at least have it
playable on the player.

This fixes API-36

@victorges victorges requested a review from a team as a code owner March 21, 2023 19:11
@linear
Copy link

linear bot commented Mar 21, 2023

API-36 error with nft metadata when set to 'player'

There is an error when uploading to IPFS on create when passing in the player template

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #170 (89919db) into main (66147fb) will not change coverage.
The diff coverage is 0.00000%.

❗ Current head 89919db differs from pull request most recent head e38ad08. Consider uploading reports for the commit e38ad08 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #170   +/-   ##
=============================================
  Coverage   10.86957%   10.86957%           
=============================================
  Files             14          14           
  Lines           2162        2162           
=============================================
  Hits             235         235           
  Misses          1910        1910           
  Partials          17          17           
Impacted Files Coverage Δ
task/export.go 0.00000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66147fb...e38ad08. Read the comment docs.

Impacted Files Coverage Δ
task/export.go 0.00000% <0.00000%> (ø)

A bit weird interface tbh but it's like that in the API
today and I don't wanna mess with it.
@victorges victorges merged commit ededb39 into main Mar 22, 2023
@victorges victorges deleted the vg/fix/player-nft-metadata-on-creation branch March 22, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants