Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Make 4xx errors from Catalyst unretriable #175

Merged
merged 2 commits into from
Mar 24, 2023

Conversation

victorges
Copy link
Member

This is to improve our error classification and both not retry as well as not alert from user-input errors on the request to Catalyst (normally bad input URLs).

This is to improve our error classification and both
not retry as well as not alert from user-input errors
on the request to Catalyst (normally bad input URLs).
@victorges victorges requested a review from a team as a code owner March 23, 2023 15:54
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #175 (5cfd3a8) into main (ededb39) will decrease coverage by 0.03300%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #175         +/-   ##
===================================================
- Coverage   11.95201%   11.91901%   -0.03300%     
===================================================
  Files             14          14                 
  Lines           2167        2173          +6     
===================================================
  Hits             259         259                 
- Misses          1889        1895          +6     
  Partials          19          19                 
Impacted Files Coverage Δ
clients/catalyst.go 83.95062% <0.00000%> (-4.36107%) ⬇️
task/upload.go 6.68103% <0.00000%> (-0.02893%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ededb39...5cfd3a8. Read the comment docs.

Impacted Files Coverage Δ
clients/catalyst.go 83.95062% <0.00000%> (-4.36107%) ⬇️
task/upload.go 6.68103% <0.00000%> (-0.02893%) ⬇️

@victorges victorges merged commit b112d74 into main Mar 24, 2023
@victorges victorges deleted the vg/fix/client-errs-handling branch March 24, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants