Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MP4 to Transcode API #176

Merged
merged 9 commits into from
Apr 3, 2023
Merged

Add MP4 to Transcode API #176

merged 9 commits into from
Apr 3, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Mar 30, 2023

It also updates the Catalyst API VOD according to the design here: https://www.notion.so/livepeer/VOD-MP4-separate-from-HLS-34efd71b091a491ea4e785dda3bf9873

@leszko leszko requested review from thomshutt and mjh1 March 30, 2023 08:39
@leszko leszko requested a review from a team as a code owner March 30, 2023 08:39
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #176 (8bafeff) into main (58ebeda) will increase coverage by 0.95848%.
The diff coverage is 60.86957%.

❗ Current head 8bafeff differs from pull request most recent head 76e0f8d. Consider uploading reports for the commit 76e0f8d to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #176         +/-   ##
===================================================
+ Coverage   11.95952%   12.91800%   +0.95848%     
===================================================
  Files             14          14                 
  Lines           2174        2183          +9     
===================================================
+ Hits             260         282         +22     
+ Misses          1895        1880         -15     
- Partials          19          21          +2     
Impacted Files Coverage Δ
clients/catalyst.go 83.95062% <ø> (ø)
task/paths.go 0.00000% <ø> (ø)
task/upload.go 11.15789% <60.86957%> (+4.47686%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ebeda...76e0f8d. Read the comment docs.

Impacted Files Coverage Δ
clients/catalyst.go 83.95062% <ø> (ø)
task/paths.go 0.00000% <ø> (ø)
task/upload.go 11.15789% <60.86957%> (+4.47686%) ⬆️

task/paths.go Outdated Show resolved Hide resolved
Copy link
Contributor

@thomshutt thomshutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments this LGTM - I don't think either of them is a blocker, so your call on addressing them

task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
clients/catalyst.go Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
@leszko leszko requested a review from victorges March 31, 2023 07:39
@leszko leszko merged commit 5f22c6e into main Apr 3, 2023
@leszko leszko deleted the rafal/split-mp4-hls branch April 3, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants