-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MP4 to Transcode API #176
Conversation
Codecov Report
@@ Coverage Diff @@
## main #176 +/- ##
===================================================
+ Coverage 11.95952% 12.91800% +0.95848%
===================================================
Files 14 14
Lines 2174 2183 +9
===================================================
+ Hits 260 282 +22
+ Misses 1895 1880 -15
- Partials 19 21 +2
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my comments this LGTM - I don't think either of them is a blocker, so your call on addressing them
Co-authored-by: Victor Elias <victorgelias@gmail.com>
It also updates the Catalyst API VOD according to the design here: https://www.notion.so/livepeer/VOD-MP4-separate-from-HLS-34efd71b091a491ea4e785dda3bf9873