Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients: Add a timeout to catalyst client #185

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

victorges
Copy link
Member

We were waiting for 6h on "blackholed" requests before trying again.

@victorges victorges requested a review from a team as a code owner April 20, 2023 18:42
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #185 (5f59f5e) into main (a16f62c) will increase coverage by 0.03963%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #185         +/-   ##
===================================================
+ Coverage   13.14468%   13.18431%   +0.03963%     
===================================================
  Files             14          14                 
  Lines           2191        2192          +1     
===================================================
+ Hits             288         289          +1     
  Misses          1882        1882                 
  Partials          21          21                 
Impacted Files Coverage Δ
clients/catalyst.go 84.14634% <100.00000%> (+0.19572%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a16f62c...5f59f5e. Read the comment docs.

Impacted Files Coverage Δ
clients/catalyst.go 84.14634% <100.00000%> (+0.19572%) ⬆️

@victorges victorges merged commit 5965860 into main Apr 20, 2023
13 checks passed
@victorges victorges deleted the vg/fix/catalyst-timeout branch April 20, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants