Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate always MP4 output for recordings #192

Merged
merged 3 commits into from
May 5, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented May 5, 2023

No description provided.

@leszko leszko requested a review from thomshutt May 5, 2023 08:01
@leszko leszko requested a review from a team as a code owner May 5, 2023 08:01
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #192 (c48b9ed) into main (1c98ca4) will decrease coverage by 0.02321%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #192         +/-   ##
===================================================
- Coverage   13.44574%   13.42253%   -0.02321%     
===================================================
  Files             18          18                 
  Lines           2313        2317          +4     
===================================================
  Hits             311         311                 
- Misses          1978        1982          +4     
  Partials          24          24                 
Impacted Files Coverage Δ
task/upload.go 13.10484% <0.00000%> (-0.10654%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c98ca4...c48b9ed. Read the comment docs.

Impacted Files Coverage Δ
task/upload.go 13.10484% <0.00000%> (-0.10654%) ⬇️

@leszko leszko requested a review from emranemran May 5, 2023 08:36
task/upload.go Outdated Show resolved Hide resolved
leszko and others added 2 commits May 5, 2023 11:21
Co-authored-by: Thom Shutt <thomshutt@users.noreply.github.com>
@leszko leszko merged commit e2660f6 into main May 5, 2023
13 checks passed
@leszko leszko deleted the rafal/recordingv2-fix-long-mp4 branch May 5, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants