Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source playback #200

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Source playback #200

merged 2 commits into from
Jun 20, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Jun 14, 2023

No description provided.

@mjh1 mjh1 requested a review from a team as a code owner June 14, 2023 16:28
@mjh1
Copy link
Contributor Author

mjh1 commented Jun 14, 2023

@victorges how do you feel about having this initially then I do a follow up PR for splitting it out into another task like you suggested? Updated to the internal queue option now.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #200 (4fabd4a) into main (5bfc222) will increase coverage by 1.37533%.
The diff coverage is 61.11111%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #200         +/-   ##
===================================================
+ Coverage   13.72549%   15.10082%   +1.37533%     
===================================================
  Files             18          18                 
  Lines           2295        2331         +36     
===================================================
+ Hits             315         352         +37     
+ Misses          1956        1954          -2     
- Partials          24          25          +1     
Impacted Files Coverage Δ
task/runner.go 21.88139% <0.00000%> (-0.64493%) ⬇️
task/upload.go 19.34827% <100.00000%> (+5.48899%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bfc222...4fabd4a. Read the comment docs.

Impacted Files Coverage Δ
task/runner.go 21.88139% <0.00000%> (-0.64493%) ⬇️
task/upload.go 19.34827% <100.00000%> (+5.48899%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjh1 mjh1 merged commit eeb1b72 into main Jun 20, 2023
23 checks passed
@mjh1 mjh1 deleted the mh/segmented-playback branch June 20, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants