Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IPFS export for recordings #201

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Fix IPFS export for recordings #201

merged 3 commits into from
Jun 20, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Jun 19, 2023

Previously we were assuming the source file video would always be available, but for recordings this doesn't get generated. To fix we now check for a static mp4 output as well as the video file (mp4s are always generated for recordings https://github.com/livepeer/task-runner/blob/d7580fa/task/upload.go#L525).

@mjh1 mjh1 requested a review from a team as a code owner June 19, 2023 15:53
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #201 (7f96194) into main (5bfc222) will decrease coverage by 0.05955%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #201         +/-   ##
===================================================
- Coverage   13.72549%   13.66594%   -0.05955%     
===================================================
  Files             18          18                 
  Lines           2295        2305         +10     
===================================================
  Hits             315         315                 
- Misses          1956        1966         +10     
  Partials          24          24                 
Impacted Files Coverage Δ
task/export.go 0.00000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bfc222...7f96194. Read the comment docs.

Impacted Files Coverage Δ
task/export.go 0.00000% <0.00000%> (ø)

@mjh1 mjh1 merged commit 9b58f73 into main Jun 20, 2023
13 checks passed
@mjh1 mjh1 deleted the mh/recording-export branch June 20, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants