-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single download pipeline #203
Conversation
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
===================================================
- Coverage 14.78992% 14.77750% -0.01242%
===================================================
Files 19 19
Lines 2380 2382 +2
===================================================
Hits 352 352
- Misses 2003 2005 +2
Partials 25 25
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one comment. Other than that, I have 2 concerns (discussed in Discord):
- Do we need this PR if we plan to remove copying from task-runner at all?
- The output asset has changed. Isn't that an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Initial step towards avoiding task runner needing to download the source file. We check if the file already exists (from catalyst) and skip making the copy at task runner if so. Both cases have been tested by using a local version of catalyst-api with the source copy happening and without.
Also removing the metadata file which we deemed is not needed.