Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable catalyst source copying #204

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Enable catalyst source copying #204

merged 3 commits into from
Jul 13, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Jul 5, 2023

  • This enables source copying at catalyst for upload tasks (and not transcode-file) by setting the SourceMp4 flag on the catalyst request.
  • Removed unused function removeCredentials

@mjh1 mjh1 requested a review from a team as a code owner July 5, 2023 16:12
@mjh1 mjh1 requested a review from victorges July 5, 2023 16:12
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM anyway, but made some comments regarding the "loosiness" of the current interface and the location where some things are being done (complement vs process).

All comments are optional, feel free to merge as is.

task/upload.go Show resolved Hide resolved
task/upload.go Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #204 (e461247) into main (84726bf) will increase coverage by 0.62334%.
The diff coverage is 12.50000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #204         +/-   ##
===================================================
+ Coverage   14.77750%   15.40084%   +0.62334%     
===================================================
  Files             19          19                 
  Lines           2382        2370         -12     
===================================================
+ Hits             352         365         +13     
+ Misses          2005        1981         -24     
+ Partials          25          24          -1     
Impacted Files Coverage Δ
task/import.go 0.00000% <0.00000%> (ø)
task/upload.go 22.03742% <13.33333%> (+2.76764%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84726bf...e461247. Read the comment docs.

Impacted Files Coverage Δ
task/import.go 0.00000% <0.00000%> (ø)
task/upload.go 22.03742% <13.33333%> (+2.76764%) ⬆️

... and 1 file with indirect coverage changes

@mjh1 mjh1 merged commit cac01b9 into main Jul 13, 2023
13 checks passed
@mjh1 mjh1 deleted the mh/single-download branch July 13, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants