Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log the error when checking source copy #208

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Log the error when checking source copy #208

merged 1 commit into from
Jul 18, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Jul 18, 2023

No description provided.

@mjh1 mjh1 requested a review from a team as a code owner July 18, 2023 14:48
@mjh1 mjh1 requested a review from leszko July 18, 2023 14:48
@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited

Codecov Report

Merging #208 (f448f8c) into main (d82ebe8) will not change coverage.
The diff coverage is 0.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #208   +/-   ##
=============================================
  Coverage   15.47218%   15.47218%           
=============================================
  Files             19          19           
  Lines           2372        2372           
=============================================
  Hits             367         367           
  Misses          1981        1981           
  Partials          24          24
Impacted Files Coverage Δ
task/upload.go 22.03742% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d82ebe8...f448f8c. Read the comment docs.

Impacted Files Coverage Δ
task/upload.go 22.03742% <0.00000%> (ø)

victorges
victorges approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjh1 mjh1 merged commit ca8f235 into main Jul 18, 2023
13 checks passed
@mjh1 mjh1 deleted the mh/log branch July 18, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

@leszko leszko Awaiting requested review from leszko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjh1 @victorges