Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove probing - catalyst adds all the appropriate fields now #212

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Aug 29, 2023

No description provided.

@mjh1 mjh1 requested a review from a team as a code owner August 29, 2023 14:32
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #212 (351815c) into main (182acb0) will increase coverage by 0.02566%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #212         +/-   ##
===================================================
+ Coverage   15.32999%   15.35565%   +0.02566%     
===================================================
  Files             19          19                 
  Lines           2394        2390          -4     
===================================================
  Hits             367         367                 
+ Misses          2001        1997          -4     
  Partials          26          26                 
Files Changed Coverage Δ
task/upload.go 21.24248% <0.00000%> (+0.16892%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 182acb0...351815c. Read the comment docs.

Files Changed Coverage Δ
task/upload.go 21.24248% <0.00000%> (+0.16892%) ⬆️

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiice

@mjh1
Copy link
Contributor Author

mjh1 commented Sep 1, 2023

@victorges does the final logic look ok to you?

@mjh1 mjh1 merged commit 10cd899 into main Sep 1, 2023
25 checks passed
@mjh1 mjh1 deleted the mh/probing branch September 1, 2023 15:19
@victorges
Copy link
Member

@mjh1 Sorry didnt see the comment til now. It does look good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants