Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clip: added clip task handling #217

Merged
merged 17 commits into from
Sep 27, 2023
Merged

clip: added clip task handling #217

merged 17 commits into from
Sep 27, 2023

Conversation

gioelecerati
Copy link
Member

No description provided.

@gioelecerati gioelecerati requested a review from a team as a code owner September 21, 2023 14:43
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #217 (a5343af) into main (3e49990) will decrease coverage by 1.27954%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #217         +/-   ##
===================================================
- Coverage   18.80531%   17.52577%   -1.27954%     
===================================================
  Files             16          16                 
  Lines           1808        1940        +132     
===================================================
  Hits             340         340                 
- Misses          1443        1575        +132     
  Partials          25          25                 
Files Coverage Δ
clients/catalyst.go 84.14634% <ø> (ø)
task/runner.go 22.19959% <ø> (ø)
task/upload.go 16.79873% <0.00000%> (-4.44375%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e49990...a5343af. Read the comment docs.

Files Coverage Δ
clients/catalyst.go 84.14634% <ø> (ø)
task/runner.go 22.19959% <ø> (ø)
task/upload.go 16.79873% <0.00000%> (-4.44375%) ⬇️

@gioelecerati gioelecerati marked this pull request as draft September 21, 2023 14:54
@gioelecerati gioelecerati marked this pull request as ready for review September 22, 2023 16:55
task/upload.go Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
@gioelecerati gioelecerati merged commit 7cd9df1 into main Sep 27, 2023
13 checks passed
@gioelecerati gioelecerati deleted the gio/task/clip branch September 27, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants