Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to send partial result / source playback for transcode API #219

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Sep 28, 2023

Verified locally with box 👍

@mjh1 mjh1 requested a review from a team as a code owner September 28, 2023 12:14
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #219 (326c828) into main (3e49990) will decrease coverage by 1.10984%.
Report is 1 commits behind head on main.
The diff coverage is 2.58065%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #219         +/-   ##
===================================================
- Coverage   18.80531%   17.69547%   -1.10984%     
===================================================
  Files             16          16                 
  Lines           1808        1944        +136     
===================================================
+ Hits             340         344          +4     
- Misses          1443        1575        +132     
  Partials          25          25                 
Files Coverage Δ
clients/catalyst.go 84.14634% <ø> (ø)
task/runner.go 22.19959% <ø> (ø)
task/upload.go 17.32283% <2.58065%> (-3.91965%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd9df1...326c828. Read the comment docs.

Files Coverage Δ
clients/catalyst.go 84.14634% <ø> (ø)
task/runner.go 22.19959% <ø> (ø)
task/upload.go 17.32283% <2.58065%> (-3.91965%) ⬇️

@mjh1 mjh1 merged commit 29b8cd9 into main Sep 28, 2023
13 checks passed
@mjh1 mjh1 deleted the mh/fix-result-partial branch September 28, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants