Dont humanize errors from internal segmenting #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
===================================================
+ Coverage 17.69547% 17.82229% +0.12682%
===================================================
Files 16 16
Lines 1944 1947 +3
===================================================
+ Hits 344 347 +3
Misses 1575 1575
Partials 25 25
Continue to review full report in Codecov by Sentry.
|
victorges
approved these changes
Oct 3, 2023
leszko
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an issue with a segment generated by us then we don't want to humanize this as it won't be retried and will be presented to the user as an input error. Instead the job should be retried and investigated by us if persistent.