Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VOD thumbnails #223

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Support for VOD thumbnails #223

merged 2 commits into from
Oct 23, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Oct 20, 2023

Plus refactored the outputLocations function a little to reduce the repetition and growing param list.

@mjh1 mjh1 requested a review from a team as a code owner October 20, 2023 11:12
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #223 (6122d6a) into main (d8fa8b6) will decrease coverage by 0.19327%.
The diff coverage is 40.42553%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #223         +/-   ##
===================================================
- Coverage   17.82229%   17.62902%   -0.19327%     
===================================================
  Files             16          16                 
  Lines           1947        1957         +10     
===================================================
- Hits             347         345          -2     
- Misses          1575        1587         +12     
  Partials          25          25                 
Files Coverage Δ
clients/catalyst.go 84.14634% <ø> (ø)
task/upload.go 16.74419% <40.42553%> (-0.57864%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fa8b6...6122d6a. Read the comment docs.

Files Coverage Δ
clients/catalyst.go 84.14634% <ø> (ø)
task/upload.go 16.74419% <40.42553%> (-0.57864%) ⬇️

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice refact 🙏
Comments are all nits/style, feel free to merge as is.

task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
task/upload.go Outdated Show resolved Hide resolved
@mjh1 mjh1 merged commit f38d442 into main Oct 23, 2023
13 checks passed
@mjh1 mjh1 deleted the mh/thumbs branch October 23, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants