Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable thumbs for all studio vod jobs #226

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Enable thumbs for all studio vod jobs #226

merged 1 commit into from
Nov 20, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Nov 20, 2023

No description provided.

@mjh1 mjh1 requested a review from a team as a code owner November 20, 2023 12:30
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #226 (fb10e88) into main (e6d9ed4) will increase coverage by 0.03563%.
The diff coverage is 0.00000%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #226         +/-   ##
===================================================
+ Coverage   17.51269%   17.54832%   +0.03563%     
===================================================
  Files             16          16                 
  Lines           1970        1966          -4     
===================================================
  Hits             345         345                 
+ Misses          1600        1596          -4     
  Partials          25          25                 
Files Coverage Δ
task/upload.go 16.51376% <0.00000%> (+0.10039%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d9ed4...fb10e88. Read the comment docs.

Files Coverage Δ
task/upload.go 16.51376% <0.00000%> (+0.10039%) ⬆️

@mjh1 mjh1 merged commit 34247f4 into main Nov 20, 2023
13 checks passed
@mjh1 mjh1 deleted the mh/enable-thumbs branch November 20, 2023 15:11
@emranemran
Copy link
Contributor

LGTM, main concern is the ffmpeg calls on every segment which will increase our pod loads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants