clients: Add rate limit handling to catalyst client #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomshutt
approved these changes
Nov 30, 2022
victorges
force-pushed
the
vg/feat/catalyst-rate-limit
branch
from
0ff1485
to
3373922
Compare
thomshutt
reviewed
Nov 30, 2022
Total retry time will be shorter, 14s of cumulative sleep, which seems better overall: try 4 times in 15 seconds, then backoff asynchronously for a minute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple logic, just waiting 15 seconds between each attempt. Should be fine since the request is also really cheap on catalyst side when it gets rate limited, and there will be at most 5 of these looping per task runner instance (3 instances)
My only concern now is that if we're operating at full capacity, these 5 executions will also block handling of any events from the currently running jobs. So we might stop checking if we're getting catalyst callbacks and handling the result callbacks (they become events as well).
Should consider reusing the "delayed task" abstraction used for checking catalyst callbacks for this as well, as a pre-step on the upload task execution in case it got rate limited.
Edit: Fixed the above and implemented an async back off through the delayed event.