-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/runner: Several reliability improvements #95
Conversation
Codecov Report
@@ Coverage Diff @@
## main #95 +/- ##
===================================================
- Coverage 38.64734% 5.45262% -33.19472%
===================================================
Files 3 14 +11
Lines 207 1889 +1682
===================================================
+ Hits 80 103 +23
- Misses 119 1777 +1658
- Partials 8 9 +1
Continue to review full report at Codecov.
|
Move it to the outer function in runner so we catch errors in the runner code as well
we dont want to not sent the publish result because we already expired the task contexst or something.
Just so the deploys can be safe
8a4a313
to
d425728
Compare
This is to make several reliability improvemenets towards the 12/16 launch milestone.
Included changes:
mandatory: true
(although later I realized that to get full benefits we need more logic in the AMQP producer)