Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload: Allow overriding strategy on upload request #97

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

@victorges victorges requested a review from a team as a code owner December 7, 2022 10:08
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #97 (0b070e8) into main (f782ca2) will decrease coverage by 33.18315%.
The diff coverage is 18.69159%.

❗ Current head 0b070e8 differs from pull request most recent head 107f4eb. Consider uploading reports for the commit 107f4eb to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #97          +/-   ##
===================================================
- Coverage   38.64734%   5.46419%   -33.18315%     
===================================================
  Files              3         14          +11     
  Lines            207       1885        +1678     
===================================================
+ Hits              80        103          +23     
- Misses           119       1773        +1654     
- Partials           8          9           +1     
Impacted Files Coverage Δ
clients/catalyst.go 94.82759% <ø> (ø)
task/prepare.go 0.00000% <0.00000%> (ø)
task/transcode.go 1.29310% <0.00000%> (ø)
task/upload.go 0.00000% <0.00000%> (ø)
task/runner.go 5.40541% <20.61856%> (ø)
task/readers.go 0.00000% <0.00000%> (ø)
task/probe.go 0.00000% <0.00000%> (ø)
task/import.go 0.00000% <0.00000%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f782ca2...107f4eb. Read the comment docs.

Impacted Files Coverage Δ
clients/catalyst.go 94.82759% <ø> (ø)
task/prepare.go 0.00000% <0.00000%> (ø)
task/transcode.go 1.29310% <0.00000%> (ø)
task/upload.go 0.00000% <0.00000%> (ø)
task/runner.go 5.40541% <20.61856%> (ø)
task/readers.go 0.00000% <0.00000%> (ø)
task/probe.go 0.00000% <0.00000%> (ø)
task/import.go 0.00000% <0.00000%> (ø)
... and 6 more

@victorges victorges force-pushed the vg/feat/catalyst-pipeline-override branch from f6b0333 to 0b070e8 Compare December 7, 2022 10:17
@victorges victorges changed the base branch from main to vg/chore/reliability-improvements December 7, 2022 11:00
@victorges victorges force-pushed the vg/feat/catalyst-pipeline-override branch from 0b070e8 to 107f4eb Compare December 7, 2022 11:19
@victorges victorges changed the base branch from vg/chore/reliability-improvements to main December 7, 2022 11:19
@victorges victorges merged commit c266111 into main Dec 7, 2022
@victorges victorges deleted the vg/feat/catalyst-pipeline-override branch December 7, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants