Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore CSSImportRule with no href #84

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Ignore CSSImportRule with no href #84

merged 1 commit into from
Dec 28, 2019

Conversation

bep
Copy link
Contributor

@bep bep commented Jul 22, 2019

Fixes #83

@smhg
Copy link
Contributor

smhg commented Jul 22, 2019

Thank you for this PR!
Can you please add applicable test(s)?

@bep
Copy link
Contributor Author

bep commented Jul 22, 2019

@smhg sorry, I had a quick look at the existing tests, and I didn't find a similar test to mimick -- so that sadly makes it a too time-consuming task for me at the moment. I may revisit this in the future if no-one else steps up to the plate.

@smhg
Copy link
Contributor

smhg commented Jul 22, 2019

I understand. I'm trying to taking care of this project, but some parts (including tests) need more attention.
I've added a basic test for the Reloader class to master hoping you can pick up and implement another basic test for your change. Any test is a win!
I'm happy to release it immediately after.

@smhg smhg merged commit 08654ac into livereload:master Dec 28, 2019
smhg added a commit that referenced this pull request Dec 28, 2019
jmooring added a commit to jmooring/hugo that referenced this pull request May 1, 2024
We no longer need a patched version because livereload/livereload-js#84
was merged on 28 Dec 2019.

Closes gohugoio#6290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails on @import inside stylesheets
2 participants