Camelcase properties don't get shortened in validation messages properly

[JoshMoreno]

Description

The attribute name is not shortened when using model property binding if the property name is camelcase.
In the example below naming the property $companyProfile results in this bug. Snake case and all lower case work as expected:

$company_profile
$companyprofile

Exact steps to reproduce

1. Create the CompanyProfile model with a string name column.
2. Create the livewire component and blade template.
3. Without filling the form out, submit and you'll see an error message that reads:

The company profile.name field is required.

It should read:

The company name field is required.

Stripped-down, copy-pastable code snippets

app/Http/Livewire/UpdateCompanyProfileForm.php

<?php

namespace App\Http\Livewire;

use App\Models\CompanyProfile;
use Livewire\Component;

class UpdateCompanyProfileForm extends Component
{
    public CompanyProfile $companyProfile;

    protected $rules = [
        'companyProfile.name' => 'required|string',
    ];

    public function mount()
    {
        $this->companyProfile = new CompanyProfile;
    }

    /**
     * Get the view / contents that represent the component.
     *
     * @return \Illuminate\View\View|string
     */
    public function render()
    {
        return view('livewire.update-company-profile-form');
    }

    public function save()
    {
        $this->validate();
    }
}

resources/views/livewire/update-company-profile-form.blade.php

<form wire:submit.prevent="save">
    <input
        wire:model.defer="companyProfile.name"        
    />
    @error('companyProfile.name')
        <p>{{ $message }}</p>
    @enderror

</form>

Fix

https://github.com/livewire/livewire/blob/master/src/ComponentConcerns/ValidatesInput.php#L212

protected function shortenModelAttributes($data, $rules, $validator)
    {
        // If a model ($foo) is a property, and the validation rule is
        // "foo.bar", then set the attribute to just "bar", so that
        // the validation message is shortened and more readable.
        foreach ($rules as $key => $value) {
            $propertyName = $this->beforeFirstDot($key);

            if ($data[$propertyName] instanceof Model) {
-                if (str($key)->replace('_', ' ')->is($validator->getDisplayableAttribute($key))) {
+                if (str($key)->snake()->replace('_', ' ')->is($validator->getDisplayableAttribute($key))) {
                    $validator->addCustomAttributes([$key => $validator->getDisplayableAttribute($this->afterFirstDot($key))]);
                }
            }
        }
    }

Context

• Livewire version: 2.3.2
• Laravel version: 8.15.0
• Alpine version: 2.7.3
• Browser: Chrome 87.0.4280.67

[iksaku]

If your provided solution does indeed work, would you mind opening a PR and add the necessary tests?

[austenc]

@JoshMoreno thanks for the suggestion on the fix -- added a PR for it #2229 with a test.

[squishythejellyfish]

👋 Oh Hi! I'm Squishy, the friendly jellyfish that manages Livewire issues.

I see this issue has been closed.

Here in the Livewire repo, we have an "issues can be closed guilt-free and without explanation" policy.

If for ANY reason you think this issue hasn't been resolved, PLEASE feel empowered to re-open it.

Re-opening actually helps us track which issues are a priority.

Reply "REOPEN" to this comment and we'll happily re-open it for you!

(More info on this philosophy here: https://twitter.com/calebporzio/status/1321864801295978497)