fix: correct typeof check for IE11 documentMode #1226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it does a string comparison which would always be false.
I.e.
window.document.documentMode == 'undefined'
.It should be:
typeof window.document.documentMode == 'undefined'
in order to useevent.detail
I ran into this issue as my payload was sent back for
syncInput
withname
set butvalue
was always undefined. This is when using Apline's$dispatch('input', value')
.I think it is a regression introduced from the autofill issue:
Commit: 15ac0ba
Author: Jason Mountcastle git@aspn.dev
Date: Tuesday, 30 June, 2020 01:15:34 AM PST