Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psr client to build URL #1449

Merged
merged 1 commit into from Sep 11, 2020
Merged

Conversation

jimmypuckett
Copy link
Contributor

1️⃣ Is this something that is wanted/needed? Did you create an issue / discussion about it first?

This is part of #1294 in that it allows the PSR client to set the URL.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

No

3️⃣ Does it include tests, if possible? (Not a deal-breaker, just a nice-to-have)

No

4️⃣ Please include a thorough description of the improvement and reasons why it's useful.

In the current code, when the temp URL is created, it is being manually made, but not taking into consideration schema & port, so it will not work when running s3 compatable storage on non https. This just cast GuzzleHttp\Psr7\Uri to a string, so it keeps up with the correct path

5️⃣ Thanks for contributing! 🙌

@jimmypuckett
Copy link
Contributor Author

@calebporzio I know you are busy with v2, but any chance you can review this? We trying to use a minio container locally to develop & test, but cannot with the way that URL's are made.

@calebporzio calebporzio merged commit 1b618c7 into livewire:1.x Sep 11, 2020
@calebporzio
Copy link
Collaborator

Thanks @jimmypuckett !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants