Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ Is this something that is wanted/needed? Did you create an issue / discussion about it first?
This is part of #1294 in that it allows the PSR client to set the URL.
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No
3️⃣ Does it include tests, if possible? (Not a deal-breaker, just a nice-to-have)
No
4️⃣ Please include a thorough description of the improvement and reasons why it's useful.
In the current code, when the temp URL is created, it is being manually made, but not taking into consideration
schema
&port
, so it will not work when running s3 compatable storage on non https. This just castGuzzleHttp\Psr7\Uri
to a string, so it keeps up with the correct path5️⃣ Thanks for contributing! 🙌