New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow 'validationOnly' to use validation messages property #1568

Merged

calebporzio merged 1 commit into livewire:master from iksaku:validation_only_with_message_property

Sep 13, 2020

Contributor

iksaku commented Sep 12, 2020

1️⃣ Is this something that is wanted/needed? Did you create an issue / discussion about it first?

Was commented on a previous PR.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

Straight implementation

3️⃣ Does it include tests, if possible? (Not a deal-breaker, just a nice-to-have)

Simple working test 🌟

4️⃣ Please include a thorough description of the improvement and reasons why it's useful.

The Adds the ability to define Validation Messages via property #1518 pull added the ability to define a protected $messages property that allowed validation function to use those messages, but it only worked for the validate() function. I missed the validateOnly() one, but it was brought to my attention after the PR was merged. So, this is to fix that 😅

5️⃣ Thanks for contributing! 🙌


          Allow 'validationOnly' to use validation messages property

6ef7aa4

Collaborator

calebporzio commented Sep 13, 2020

Perfect! Thanks!

calebporzio merged commit ad3f8de into livewire:master

iksaku deleted the validation_only_with_message_property branch

October 2, 2020 05:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment