Support File Uploads as Nested Properties Within Multi Typed Object

[iantasker]

1️⃣ Is this something that is wanted/needed? Did you create an issue / discussion about it first?

This is a bug fix for #1714

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

No

3️⃣ Does it include tests, if possible? (Not a deal-breaker, just a nice-to-have)

Yes

4️⃣ Please include a thorough description of the improvement and reasons why it's useful.

Its resolves an an issue with the file upload component not correctly rehydrating an object with non string or array properties after a file has been uploaded.

5️⃣ Thanks for contributing! 🙌

[iksaku]

Super clean fix 🤩

How about changing reference from "numbers can be updated"? It is only a side-effect of losing track of the state of the property, so I suggest renaming to something referencing "Support File Uploads for Nested Component Properties".

[iantasker]

@iksaku It might be easier to extend the it_can_upload_single_file_with_in_array_public_property and it_can_upload_multiple_file_with_in_array_public_property tests as the scopes are pretty much the same.

Would you be happy with that?

[iksaku]

Sure, that would better describe what the test is intended to do.

PS: I think it is written "within" (without space) 🤔.

[iantasker]

@iksaku I will also update the test name as I agree it should be within not with in

[stancl]

Just tested this in Lean and it works perfectly.

As I said in #1714, I'll be paying a $100 bounty for this.

@iantasker please DM me your payment details on Discord. I'll also invite you to Lean for free.

@calebporzio please merge this soon, it's tested both with PHPUnit and in a real app and I'd really love to be able to use this 😅

[iantasker]

@iksaku I have consolidated the tests so this is good to merge now.

[calebporzio]

Fantastic work everyone. Thanks