Simultaneous $wire method calls always return the value of the last call

[danharrin]

Failing test for #3065.

[calebporzio]

@danharrin - good catch. This is a bug. Here's what's happening:

The Problem

After an "action" (component method) is called, the returned value is captured and dealt with in the following line of code:

livewire/src/Features/SupportActionReturns.php

Line 21 in adaa7f9

$this->returnsByIdAndAction[$component->id][$action] = $returned;

As you can see, the returned values are stored in a key/value pair where the key is the action name.

Therefore, if the same action is called twice with different returns, the last executed one will overwrite the previous one and both will be used on the front-end.

The Solution

I see two solution paths:

A) Assign a unique identifier/signature to each action on the front-end before the request is fired, then change the key/value pair to use the action "signature" instead of the action name, that way information can be tracked properly.

B) Preserve the current schema, but allow for arrays of return values in the order of execution - then, assuming the order is preserved throughout the lifecycle, the front-end can retrieve the proper return value.

Which one to choose depends on how well the order of actions is preserved throughout the request/response. And also if it is preserved, do we want to depend on that order preservation.

My gut tells me an action "signature" is the right way to go here, my only hesitancy is adding a new concept to the payloads and adding extra bytes to every single request/response - the latter is probably negligible, but it's always a consideration with Livewire.

What are your thoughts?

[danharrin]

Thanks for the insight! I was discussing this with @joshhanley the other day and we settled on the signature approach too - didn't consider the performance implications but IMHO this is really not a massive problem.

Would you like to implement the solution yourself or do you want me to have a go / pair with you?

[calebporzio]

I'll have a go at this myself - also, this failing test was failing for the wrong reasons - I updated it.

[calebporzio]

Thanks for bringing this up @danharrin. I went with the signature route and test is now passing.

[danharrin]

Awesome, thanks Caleb!

[Casmo]

Since this update I get the following error: Undefined index: id on
vendor/livewire/livewire/src/HydrationMiddleware/PerformActionCalls.php:27

[joshhanley]

@Casmo please see this pinned discussion on how to fix #3769