[Fix] Add flush state and feature listeners to support Octane #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some of Livewire's feature classes are retaining state between requests when using Octane, see #2859,#3492, #3509.
This PR adds a method to the
LivewireManagerclass calledflushStatethat fires an internal Livewire event, that the feature classes can listen to and reset their own state.A corresponding PR will be submitted to Octane, with an Octane listener that triggers this
flushStatemethod as required to prepare for new requests.This will allow us to add new features to Livewire without needing to add a corresponding PR to Octane.
Hope this helps!
Edit: Here is the Octane PR laravel/octane#400