-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline-flex to wire:loading #4246
Conversation
@Francismori7 thanks for the PR! It seems like there is a failure in one of your tests |
Can you run it again? The javascript wasn't built. I did now. |
@Francismori7 ah yep, I'll start them now! |
If the tests are passing the conflicts have been resolved, I'll merge this - sorry for the extra work on such a simple addition. Thanks @Francismori7! and thanks @joshhanley for helping out here |
The merge conflicts are due to the compiled files, how can I resolve them? |
@Francismori7 best thing to do would just be to merge the latest commits on the master branch into your feature branch, and then rebuild assets again and do another commit of the assets. |
All done! |
Thanks @Francismori7! Can you add a bit about this support to the livewire/docs? Thanks! |
Sure thing. |
When you are trying to inline-flex a loading element, just like for instance you want to center the loading message inside a table's
td
, you need it to be inline-flex.