Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it compatible with PHP 7.1 #525

Merged
merged 1 commit into from Jan 17, 2020
Merged

Make it compatible with PHP 7.1 #525

merged 1 commit into from Jan 17, 2020

Conversation

lalov
Copy link

@lalov lalov commented Jan 15, 2020

Removed some trailing commas to make it work with PHP 7.1

@cbaconnier
Copy link

Shouldn't we add PHP 7.1 to Github actions test workflow ?

https://github.com/livewire/livewire/blob/master/.github/workflows/test.yml#L17

@lalov
Copy link
Author

lalov commented Jan 16, 2020

Should I add PHP 7.1 to Github actions test workflow before it can be pulled in?

@calebporzio calebporzio merged commit 456a54b into livewire:master Jan 17, 2020
@calebporzio
Copy link
Collaborator

Thanks!

@lancepioch
Copy link
Contributor

@all-contributors please add @lalov for maintenance

@allcontributors allcontributors bot mentioned this pull request Jan 23, 2020
Merged
@allcontributors
Copy link
Contributor

@lancepioch

I've put up a pull request to add @lalov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebporzio calebporzio Awaiting requested review from calebporzio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lalov @cbaconnier @calebporzio @lancepioch