Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop creation of livewire class and view if name is not allowed / reserved #531

Merged
merged 2 commits into from Jan 17, 2020
Merged

Conversation

intellow
Copy link
Contributor

1️⃣ Is this something that is wanted/needed? Did you create a feature-request issue first?
When you try to make a component with a reserved name, everything blows up. I think it's needed but there's no issue.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
Nope, this is self contained.

3️⃣ Does it include tests if possible? (Not a deal-breaker, just a nice-to-have)
Yes

4️⃣ Please include a thorough description of the feature/fix and reasons why it's useful.
When you make:livewire parent or make:livewire component the classes are created and everything breaks. I have added a check to make sure those classes cannot be created. If there is a definitive list of what class names are reserved, it would be great to use that. Right now I've just captured three I've seen (Parent, Component, Interface)

5️⃣ Thanks for contributing! 🙌
👍

@calebporzio
Copy link
Collaborator

Thanks @intellow - good PR. Made a few tiny updates (will add GH review comments on the lines for you to look at)

@calebporzio calebporzio merged commit d7043c2 into livewire:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants