-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Fix broken IE11 support by transpiling spread syntax using babel #586
Conversation
Hey @calebporzio I will check this out tomorrow and follow up. Thanks for letting me know! |
Fixed by adding |
oof, you're right my rebase was not the best way to go. I'll clean up the branch later and ping you! |
Any progress on this? |
@calebporzio Fixed the rebase, now JS tests are working too for me! |
Thanks! |
@all-contributors please add @ruudschuurmans for maintenance |
I've put up a pull request to add @ruudschuurmans! 🎉 |
1️⃣ Is this something that is wanted/needed? Did you create a feature-request issue first?
Yes! It fixes the issue of Livewire not initializing in both IE11 and Edge. The issue can be found here: #585
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
Nope
3️⃣ Does it include tests if possible? (Not a deal-breaker, just a nice-to-have)
Nope
4️⃣ Please include a thorough description of the feature/fix and reasons why it's useful.
https://babeljs.io/docs/en/babel-plugin-proposal-object-rest-spread which is not supported in IE11 and early versions of Edge
I have tested this in Edge using Browserstack and it seems to work.
More info on spread syntax compatibility:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax#Spread_in_object_literals
5️⃣ Thanks for contributing! 🙌
More than welcome, thanks for Livewire.