New SOURCE Group and TARGET Group attributes for quick identification of Dragged Item, and Filtering (wire:sortable-group.filter-updated) #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it faster to identify the Item dragged and its Source and Target groups, I've modified the sortable:stop event This is a non-breaking change -- it only adds additional attributes NOTE: If Group has Source and Target attributes as True, it means the Item was dragged within that group, rather than to another group Adding wire:sortable-group.filter-updated attribute will filter only groups updated
|
Thanks for contributing! In order to keep this project as focused and maintainable as possible, I'm going to close this pull request. This isn't "no", it's just "no for now". If you disagree, or there's further demand from the community, please re-open this PR and we'll reconsider! |
|
I think this is a needed pull request, because the enhancements make it helpful for devs to know if the Dragged item has moved within the SAME GROUP or to ANOTHER GROUP without having to roll this functionality themselves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it faster to identify the Item dragged and its Source and Target groups, I've modified the sortable:stop event
This is a non-breaking change -- it only adds additional attributes
NOTE: If Group has Source and Target attributes as True, it means the Item was dragged within that group, rather than to another group
Adding wire:sortable-group.filter-updated attribute will filter only groups updated by drag
https://user-images.githubusercontent.com/20057194/206751855-2687fb1b-9a7c-4545-b81a-e6be7b9df2ca.png