Now.sh configuration #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavdi
force-pushed
the
feat/deploy-now-sh
branch
from
f1c8b3a
to
7daddd9
Compare
package.json
Outdated
| "design:build": "NODE_ENV=production webpack --display-error-details", | ||
| "design:publish": "npm run design:build && ldm design:publish design/dist", | ||
| "now-build": "npm run design:build", | ||
| "now-deploy": "now", | ||
| "now-start": "ENVIRONMENT=now node app/index.js", | ||
| "start:json-server": "nodemon --watch ./mocks --exec 'json-server ./mocks/db.js --routes ./mocks/routes.json --port 3001'", |
There was a problem hiding this comment.
Do we still need that and start:magazine:mocked?
There was a problem hiding this comment.
No we don't. Will change now.
mavdi
force-pushed
the
feat/deploy-now-sh
branch
from
9c7586b
to
5d4e6a2
Compare
marcbachmann
approved these changes
Sep 14, 2018
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed to get things working on
now.shjson-serverto middleware asnow.shonly supports one port at a time