Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not run on newly VS Code 1.53.0 #881

Open
NormandoHall opened this issue Feb 5, 2021 · 29 comments
Open

Not run on newly VS Code 1.53.0 #881

NormandoHall opened this issue Feb 5, 2021 · 29 comments

Comments

@NormandoHall
Copy link

NormandoHall commented Feb 5, 2021

Do you read the FAQ?

Describe the bug
I was update VS Code, and not run anymore this great extension. I need it a lot.

To Reproduce
Steps to reproduce the behavior:

  1. Go to sftp configured sites clicking at icon, then sites, and then get the error

Expected behavior
Connect

Screenshots
If applicable, add screenshots to help explain your problem.

image

image

image

Desktop (please complete the following information):
Version: 1.53.0 (user setup)
Commit: 8490d3dde47c57ba65ec40dd192d014fd2113496
Date: 2021-02-03T20:36:38.611Z
Electron: 11.2.1
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: 8.7.220.31-electron.0
OS: Windows_NT x64 6.1.7601

Extension Logs from Startup - required

  1. Open User Settings.

    • On Windows/Linux - File > Preferences > Settings
    • On macOS - Code > Preferences > Settings
  2. Set sftp.debug to true and reload vscode.

  3. Reproduce the problem, get the logs from View > Output > sftp.

Nothing from SFTP. Only alert:

command: "sftp.remoteExplorer.refresh" not found

SFTP version: 1.12.9

@NormandoHall
Copy link
Author

Seems an issue with latest vsc update:

microsoft/vscode#115818

@camoralb
Copy link

camoralb commented Feb 5, 2021

Same issue on MacOS Big Sur after vscode update. Version Version: 1.53.0

@wuzhitian
Copy link

Same issue on MacOS 11.2 Big Sur after vscode update. Version: 1.53.0

@mfunollet
Copy link

Same issue on Linux Mint 20.1 Ulyssa after VScode update to version 1.53.0 :(

@jasonwilliams
Copy link

jasonwilliams commented Feb 5, 2021

So i brought this up with VSCode, they suggested extension bisect.
It brought me back here:

"Extension Bisect is done and has identified liximomo.sftp as the extension causing the problem."
microsoft/vscode#115859

@Clinteastman
Copy link

Clinteastman commented Feb 5, 2021

Same issue on Windows 10 20H2 after vscode update. Version: 1.53.0

@waterdropct
Copy link

Same issue on Windows_NT x64 10.0.18363 after vscode update. Version: 1.53.0

@apolinux
Copy link

apolinux commented Feb 5, 2021

Same issue on Linux Ubuntu 20.04 after vscode update. version 1.53.0

@minstyle
Copy link

minstyle commented Feb 5, 2021

Same issue on Windows 10 Pro 20H2 after vscode update to version 1.53.0.

@NormandoHall
Copy link
Author

Meanwhile fix this issue, downgrade to 1.52.1 can work again

https://code.visualstudio.com/updates/v1_52

@drossi70
Copy link

drossi70 commented Feb 5, 2021

Same issue on Windows 10 Pro 20H2 after vscode update to version 1.53.0.
After install of vascode previous version the extension work.
Disabled the vascode auto-update from setting. Thanks

@3b0b
Copy link

3b0b commented Feb 6, 2021

I'm asking here because this issue has the most participants, of the seemingly related ones I've found: Has anyone had this issue on a relatively recent target host OS? I had this problem with both this extension and vscode-sshfs on the 1.53 insider build trying to connect to RHEL 6, but not connecting to RHEL 8 (SchoofsKelvin/vscode-sshfs#225). Another user of that extension reported the problem with Debian 4 (SchoofsKelvin/vscode-sshfs#239). Someone reporting what seems like it might be...well, not the root cause, but the underlying commonality (mscdex/ssh2#967) had the issue trying to connect at work, but not connecting to a raspberry (pi, I assume). Not sure there is a significance, but it at least seems potentially relevant.

@camoralb
Copy link

camoralb commented Feb 6, 2021

Yes, it´s happening in my MacOS Big Sur, but only connectiong to my hostgator hosting account. When connecting to some Debian Servers it is working without issues... Although, using cyberduck I can connect to shh without problem to hostgator.

I'm asking here because this issue has the most participants, of the seemingly related ones I've found: Has anyone had this issue on a relatively recent target host OS? I had this problem with both this extension and vscode-sshfs on the 1.53 insider build trying to connect to RHEL 6, but not connecting to RHEL 8 (SchoofsKelvin/vscode-sshfs#225). Another user of that extension reported the problem with Debian 4 (SchoofsKelvin/vscode-sshfs#239). Someone reporting what seems like it might be...well, not the root cause, but the underlying commonality (mscdex/ssh2#967) had the issue trying to connect at work, but not connecting to a raspberry (pi, I assume). Not sure there is a significance, but it at least seems potentially relevant.

@borsTiHD
Copy link

borsTiHD commented Feb 6, 2021

I'm asking here because this issue has the most participants, of the seemingly related ones I've found: Has anyone had this issue on a relatively recent target host OS? I had this problem with both this extension and vscode-sshfs on the 1.53 insider build trying to connect to RHEL 6, but not connecting to RHEL 8 (SchoofsKelvin/vscode-sshfs#225). Another user of that extension reported the problem with Debian 4 (SchoofsKelvin/vscode-sshfs#239). Someone reporting what seems like it might be...well, not the root cause, but the underlying commonality (mscdex/ssh2#967) had the issue trying to connect at work, but not connecting to a raspberry (pi, I assume). Not sure there is a significance, but it at least seems potentially relevant.

Sorry for the poor explanation of my problem. Yes, I can connect successful to a raspberry pi in my private network at home. But in my environment at work, I have the problem that my node process terminates after I tried to build up a connection to a unix server (dont know which host system though... right now...). I hope this information helps. :)

@tukerty
Copy link

tukerty commented Feb 7, 2021

same here!

Extension terminates when connecting to Centos 6 host
Debian 10 host works allright

MacOs - Big Sur
VsCode - 1.53.0
liximomo.sftp - 1.12.9

@drossi70
Copy link

drossi70 commented Feb 7, 2021 via email

@ruanimal
Copy link

ruanimal commented Feb 8, 2021

same here!

Extension terminates when connecting to Centos 6 host
Debian 10 host works allright

MacOs - Big Sur
VsCode - 1.53.0
liximomo.sftp - 1.12.9

centos 7 also works allright

@apolinux
Copy link

apolinux commented Feb 8, 2021

Same issue on Linux Ubuntu 20.04 after vscode update. version 1.53.0

I downgraded to 1.52.1 and worked again, hoping this bug is fixed.

@chrisfinnigan-S1
Copy link

Also having this issue on 1.53 Ubutu 18.04 (as described above) Reinstalling 1.52 got me working again.

@arvislacis
Copy link

For other users facing this issue - as the main problem is related to the Electron and createDiffieHellman then you can disable/remove "diffie-hellman-group-exchange-sha256" algorithm as specified in Wiki - SFTP only Config.

In other words, you need to edit sftp.json file and specify following algorithms as supported for each SFTP profile:

"algorithms": {
    "kex": [
        "ecdh-sha2-nistp256",
        "ecdh-sha2-nistp384",
        "ecdh-sha2-nistp521",
        "diffie-hellman-group14-sha1"
    ],
    "cipher": [
        "aes128-ctr",
        "aes192-ctr",
        "aes256-ctr",
        "aes128-gcm",
        "aes128-gcm@openssh.com",
        "aes256-gcm",
        "aes256-gcm@openssh.com"
    ],
    "serverHostKey": [
        "ssh-rsa",
        "ecdsa-sha2-nistp256",
        "ecdsa-sha2-nistp384",
        "ecdsa-sha2-nistp521"
    ],
    "hmac": [
        "hmac-sha2-256",
        "hmac-sha2-512",
        "hmac-sha1"
    ]
}

^ As you can see "diffie-hellman-group-exchange-sha256" is not specified. After doing this everything works fine with 1.53.x versions. Not really the best solution but still.

@NormandoHall
Copy link
Author

@arvislacis thank you so much. Runs like a charm!

@apolinux
Copy link

"algorithms": {
"kex": [
"ecdh-sha2-nistp256",
"ecdh-sha2-nistp384",
"ecdh-sha2-nistp521",
"diffie-hellman-group14-sha1"
],
"cipher": [
"aes128-ctr",
"aes192-ctr",
"aes256-ctr",
"aes128-gcm",
"aes128-gcm@openssh.com",
"aes256-gcm",
"aes256-gcm@openssh.com"
],
"serverHostKey": [
"ssh-rsa",
"ecdsa-sha2-nistp256",
"ecdsa-sha2-nistp384",
"ecdsa-sha2-nistp521"
],
"hmac": [
"hmac-sha2-256",
"hmac-sha2-512",
"hmac-sha1"
]
}

question: can I configure this as default for all profiles?

@arvislacis
Copy link

@apolinux Yes, looks like you can specify "algorithms" array at the beginning of sftp.json file and it will be applied for every profile defined in that file. Some progress there :) although looks like you still need to specify this for every project (would be nice if this could be possible in global level too, for all projects).

@NormandoHall
Copy link
Author

NormandoHall commented Feb 16, 2021

@arvislacis I have an array of objects in sftp.json file. Each object is a profile. I added algorithms inside each profile and runs ok. When I tried to place algorithms outside each profile, as another profile, get error. Also I tried outside main array of sftp.json file, and also get errors. Can you give us an example where to place algorithms object? Thanks

This is my sftp.json file

[
  {
    "name": "xxx",
    "etc": "..."
  },
  {
    "name": "yyy",
    "etc": "..."
  }
]

@arvislacis
Copy link

arvislacis commented Feb 16, 2021

@NormandoHall This works for me:

2021-02-16_21-18

I use profiles object/key to list all available profiles for specific project, as specified at - https://github.com/liximomo/vscode-sftp#profiles.

@NormandoHall
Copy link
Author

You're right @arvislacis . I was using multiple context. Thank you

@Bilalh
Copy link

Bilalh commented Mar 4, 2021

VS Code 1.54.0 (February) fixed the issue for me.

@minstyle
Copy link

minstyle commented Mar 5, 2021

VS Code 1.54.0 (February) fixed the issue for me.

After I upgraded to 1.54.1 it fixed the issue for me, too.

@dziku86
Copy link

dziku86 commented Mar 11, 2021

Downgrading from node 13.6.0 to 12.21.0 solved the issue for me.
Also implemented @arvislacis #881 (comment) fix.

VSCode 1.55.0-insider
Windows 7 ia32
node.js 12.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests