Hide download response button for non-JSON responses #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewBastin
force-pushed
the
feat/disable-non-json-download
branch
from
335f05b
to
d111e21
Compare
|
Hey @AndrewBastin, TravisBuddy Request Identifier: 44d1bcd0-ab79-11ea-b056-2f6ef3b381c7 |
|
Hey @AndrewBastin, TravisBuddy Request Identifier: 64276f80-ab79-11ea-b056-2f6ef3b381c7 |
liyasthomas
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to introduce the behaviour of the download response button above the response view to be hidden when the response is not a JSON response (detected from content-type).
This is a temporary fix for until the solution for #929 is implemented.