Roll engine to fea42a2 (11 commits)

flutter/engine@6bc33b5...fea42a2 git log 6bc33b5..fea42a2 --no-merges --oneline fea42a2 Roll src/third_party/dart 9e1adc54a7..389ccc9000 (10 commits) d6cf2bd Roll src/third_party/dart da4ccd0855..9e1adc54a7 (3 commits) 0c2a2c1 Initialize OpacityLayer&flutter#39;s matrix to identity (flutter/engine#8467) 7fd4caf Roll src/third_party/dart 1ad11facec..da4ccd0855 (6 commits) d3fbaea Android Embedding PR25: Prevent black rectangle when launching FlutterActivity (flutter/engine#8460) 99da038 Document the leak_vm flag. (flutter/engine#8462) ce7c21c Log the correct function on error in the embedder. (flutter/engine#8461) e10d464 Improve path metrics tests and docs (flutter/engine#7851) 424045c Enable shutting down all root isolates in a VM. (flutter/engine#8457) 816e3dc Roll src/third_party/dart 907c514c89..1ad11facec (7 commits) 45dc353 Roll src/third_party/skia 0e35ce27e0e9..053b2939938c (10 commits) (flutter/engine#8458) This roll also includes manual fix for @mustCallSuper update: call the super method whenever possible, and suppress warnings in tests.
liyuqian · Apr 6, 2019 · 53a2d9c · 53a2d9c
1 parent d0f89c1
commit 53a2d9c
Show file tree

Hide file tree

Showing 10 changed files with 11 additions and 6 deletions.
diff --git a/bin/internal/engine.version b/bin/internal/engine.version
@@ -1 +1 @@
-6bc33b5e144254ceab274298dd61d9d9ed0dcc8f
+fea42a25960c07648da5d7a85ef1d32723120abd
diff --git a/packages/flutter/lib/src/rendering/object.dart b/packages/flutter/lib/src/rendering/object.dart
@@ -2663,6 +2663,7 @@ abstract class RenderObject extends AbstractNode with DiagnosticableTreeMixin im
   @protected
   @override
   void debugFillProperties(DiagnosticPropertiesBuilder properties) {
+    super.debugFillProperties(properties);
     properties.add(DiagnosticsProperty<dynamic>('creator', debugCreator, defaultValue: null, level: DiagnosticLevel.debug));
     properties.add(DiagnosticsProperty<ParentData>('parentData', parentData, tooltip: _debugCanParentUseSize == true ? 'can use size' : null, missingIfNull: true));
     properties.add(DiagnosticsProperty<Constraints>('constraints', constraints, missingIfNull: true));

diff --git a/packages/flutter/lib/src/rendering/view.dart b/packages/flutter/lib/src/rendering/view.dart
@@ -250,6 +250,8 @@ class RenderView extends RenderObject with RenderObjectWithChildMixin<RenderBox>
   }
 
   @override
+  // (See the explanation below for why super is not called.)
+  // ignore: must_call_super
   void debugFillProperties(DiagnosticPropertiesBuilder properties) {
     // call to ${super.debugFillProperties(description)} is omitted because the
     // root superclasses don't include any interesting information for this

diff --git a/packages/flutter/lib/src/semantics/semantics.dart b/packages/flutter/lib/src/semantics/semantics.dart
@@ -2048,6 +2048,7 @@ class SemanticsNode extends AbstractNode with DiagnosticableTreeMixin {
 
   @override
   void debugFillProperties(DiagnosticPropertiesBuilder properties) {
+    super.debugFillProperties(properties);
     bool hideOwner = true;
     if (_dirty) {
       final bool inDirtyNodes = owner != null && owner._dirtyNodes.contains(this);

diff --git a/packages/flutter/test/foundation/diagnostics_test.dart b/packages/flutter/test/foundation/diagnostics_test.dart
@@ -35,6 +35,7 @@ class TestTree extends Object with DiagnosticableTreeMixin {
 
   @override
   void debugFillProperties(DiagnosticPropertiesBuilder properties) {
+    super.debugFillProperties(properties);
     if (style != null)
       properties.defaultDiagnosticsTreeStyle = style;
 

diff --git a/packages/flutter/test/material/tabs_test.dart b/packages/flutter/test/material/tabs_test.dart
@@ -60,7 +60,7 @@ class AlwaysKeepAliveState extends State<AlwaysKeepAliveWidget>
   bool get wantKeepAlive => true;
 
   @override
-  Widget build(BuildContext context) {
+  Widget build(BuildContext context) { // ignore: must_call_super
     return Text(AlwaysKeepAliveWidget.text);
   }
 }

diff --git a/packages/flutter/test/painting/painting_utils.dart b/packages/flutter/test/painting/painting_utils.dart
@@ -20,7 +20,7 @@ class PaintingBindingSpy extends BindingBase with ServicesBinding, PaintingBindi
   }
 
   @override
-  void initLicenses() {
+  void initLicenses() { // ignore: must_call_super
     // Do not include any licenses, because we're a test, and the LICENSE file
     // doesn't get generated for tests.
   }

diff --git a/packages/flutter/test/widgets/list_view_test.dart b/packages/flutter/test/widgets/list_view_test.dart
@@ -35,7 +35,7 @@ class AliveState extends State<Alive> with AutomaticKeepAliveClientMixin {
   bool get wantKeepAlive => widget.alive;
 
   @override
-  Widget build(BuildContext context) =>
+  Widget build(BuildContext context) => // ignore: must_call_super
      Text('${widget.index}:$wantKeepAlive');
 }
 

diff --git a/packages/flutter/test/widgets/semantics_keep_alive_offstage_test.dart b/packages/flutter/test/widgets/semantics_keep_alive_offstage_test.dart
@@ -126,7 +126,7 @@ class ProblemWidget extends StatefulWidget {
 
 class ProblemWidgetState extends State<ProblemWidget> with AutomaticKeepAliveClientMixin<ProblemWidget> {
   @override
-  Widget build(BuildContext context) {
+  Widget build(BuildContext context) { // ignore: must_call_super
     Widget child = Semantics(
       container: true,
       child: Text(widget.text),

diff --git a/packages/flutter_test/lib/src/binding.dart b/packages/flutter_test/lib/src/binding.dart
@@ -168,7 +168,7 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
   }
 
   @override
-  void initLicenses() {
+  void initLicenses() { // ignore: must_call_super
     // Do not include any licenses, because we're a test, and the LICENSE file
     // doesn't get generated for tests.
   }