Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer Alignment #56

Merged
merged 2 commits into from Mar 9, 2019
Merged

Footer Alignment #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3647e19
Footer Alignment
JamesIves Mar 9, 2019
8472a1f
Linting
JamesIves Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/App.js
View file
Open in desktop
Expand Up @@ -50,27 +50,35 @@ class App extends Component {
href={process.env.REACT_APP_LINKEDIN_ANCHOR}
role="button"
aria-label="linkedin link"
target="_blank"
rel="noopener noreferrer"
>
<LinkedInIcon />
</a>
<a
href={process.env.REACT_APP_GITHUB_ANCHOR}
role="button"
aria-label="github link"
target="_blank"
rel="noopener noreferrer"
>
<GithubIcon />
</a>
<a
href={process.env.REACT_APP_TWITTER_ANCHOR}
role="button"
aria-label="twitter link"
target="_blank"
rel="noopener noreferrer"
>
<TwitterIcon />
</a>
<a
href={process.env.REACT_APP_STACKOVERFLOW_ANCHOR}
role="button"
aria-label="stack overflow link"
target="_blank"
rel="noopener noreferrer"
>
<StackOverflowIcon />
</a>
Expand Down
6 changes: 5 additions & 1 deletion src/components/Card.js
View file
Open in desktop
Expand Up @@ -58,7 +58,11 @@ class Card extends Component {
<li key={index}>
<span className="list-title block">
{item.link ? (
<a href={item.link} rel="noopener">
<a
href={item.link}
target="_blank"
rel="noopener noreferrer"
>
{item.title}
</a>
) : (
Expand Down
21 changes: 15 additions & 6 deletions src/components/Footer.js
View file
Open in desktop
Expand Up @@ -20,12 +20,14 @@ const Footer = ({linkedIn, github, twitter, stackOverflow, copyright}) => (
role="contentinfo"
>
<div className="container">
<div className="icon-container padding-horizontal">
<div className="icon-container padding-horizontal vertical-align">
{linkedIn && (
<a
href={process.env.REACT_APP_LINKEDIN_ANCHOR}
role="button"
aria-label="linkedin link"
target="_blank"
rel="noopener noreferrer"
>
<LinkedInIcon />
</a>
Expand All @@ -35,6 +37,8 @@ const Footer = ({linkedIn, github, twitter, stackOverflow, copyright}) => (
href={process.env.REACT_APP_GITHUB_ANCHOR}
role="button"
aria-label="github link"
target="_blank"
rel="noopener noreferrer"
>
<GithubIcon />
</a>
Expand All @@ -44,6 +48,8 @@ const Footer = ({linkedIn, github, twitter, stackOverflow, copyright}) => (
href={process.env.REACT_APP_TWITTER_ANCHOR}
role="button"
aria-label="twitter link"
target="_blank"
rel="noopener noreferrer"
>
<TwitterIcon />
</a>
Expand All @@ -54,16 +60,19 @@ const Footer = ({linkedIn, github, twitter, stackOverflow, copyright}) => (
href={process.env.REACT_APP_STACKOVERFLOW_ANCHOR}
role="button"
aria-label="stack overflow link"
target="_blank"
rel="noopener noreferrer"
>
<StackOverflowIcon />
</a>
)}

{copyright && (
<div className="copyright full-width text-right">
© {new Date().getFullYear()} {process.env.REACT_APP_AUTHOR_NAME}
</div>
)}
</div>
{copyright && (
<span className="copyright">
© {new Date().getFullYear()} {process.env.REACT_APP_AUTHOR_NAME}
</span>
)}
</div>
</footer>
);
Expand Down
7 changes: 7 additions & 0 deletions src/css/_typography.scss
View file
Open in desktop
Expand Up @@ -29,3 +29,10 @@
font-weight: 800;
}

.text-center {
text-align: center;
}

.text-right {
text-align: right;
}
4 changes: 0 additions & 4 deletions src/css/_utilities.scss
View file
Open in desktop
Expand Up @@ -3,10 +3,6 @@
margin: 0 auto;
}

.text-center {
text-align: center;
}

.margin-horizontal {
margin: 2rem 0;
}
Expand Down