Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly document run time dependencies #136

Closed
ReenigneArcher opened this issue Apr 21, 2022 · 8 comments · Fixed by #190
Closed

Properly document run time dependencies #136

ReenigneArcher opened this issue Apr 21, 2022 · 8 comments · Fixed by #190
Labels
added This feature has been added and will be available in the next release. documentation Improvements or additions to documentation

Comments

@ReenigneArcher
Copy link
Member

Describe the Bug

A common question is about runtime dependencies. Let's properly document these.

deb: https://github.com/SunshineStream/Sunshine/blob/c4054c75a7fdd0c336db326af5a77171db072e49/gen-deb.in#L41

rpm: https://github.com/SunshineStream/Sunshine/blob/c4054c75a7fdd0c336db326af5a77171db072e49/gen-rpm.in#L47

Expected Behavior

No response

Additional Context

Is the rpm actually correct?

Sunshine Host Operating System and Version

Architecture

Sunshine Version

c4054c7

GPU Type

GPU Model

GPU Driver/Mesa Version

Capture Method (Linux Only)

@ReenigneArcher ReenigneArcher added the documentation Improvements or additions to documentation label Apr 21, 2022
@ReenigneArcher
Copy link
Member Author

@thatsysadmin should the requires section for the rpm include more dependencies? Could this be the cause of #138 ?

@thatsysadmin
Copy link
Contributor

It does. I need to figure that out. I need to add ffmpeg as an example, but I'm sure there are a couple more.

I still need to figure out audio.

@ReenigneArcher
Copy link
Member Author

It does. I need to figure that out. I need to add ffmpeg as an example, but I'm sure there are a couple more.

I still need to figure out audio.

Okay, maybe not a big deal right now. There's an open PR that will use cpack to create the deb, rpm, and adds a windows installer. I'm fairly certain it will include the proper dependencies for the end user (not 100% sure though). #139

@thatsysadmin
Copy link
Contributor

thatsysadmin commented Apr 29, 2022

While we're talking about this, do you know if the audio works for the Ubuntu packages for anyone else? I installed the Ubuntu package in a VM a couple of days ago and it couldn't pull the audio in. (KVM emulates an ICH9, which should use Intel drivers.)

I'm starting to get fairly busy with other things, so I might not able to figure this out for a while.

EDIT: I lied. It couldn't pull video b/c of the QXL driver.

@ReenigneArcher
Copy link
Member Author

I'm pretty sure audio works in Ubuntu, haven't verified myself though. I'd guess your problem is something with the virtual drivers. Outside of Sunshine, I had some trouble getting audio to work in a Kubuntu VM, when I finally did get it working the audio was way out of sync. I forget which drivers I used.

@thatsysadmin
Copy link
Contributor

I mispoke. It couldn't pull video through the QXL driver. My bad. I'm running on only 4 hours of sleep.

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity. Remove the stale label or comment, otherwise this will be closed in 5 days.

@github-actions github-actions bot added the stale label May 30, 2022
@ReenigneArcher ReenigneArcher added the added This feature has been added and will be available in the next release. label Jun 15, 2022
@github-actions
Copy link

This feature has been added and will be available in the next release.

@ReenigneArcher ReenigneArcher mentioned this issue Jun 15, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added This feature has been added and will be available in the next release. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants