-
-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sunshine to appimage.github.io #151
Comments
This issue is stale because it has been open for 30 days with no activity. Remove the stale label or comment, otherwise this will be closed in 5 days. |
ReenigneArcher
changed the title
Add Sunshine to AppImage hub
Add Sunshine to appimage.github.io
Nov 2, 2022
AppImage/appimage.github.io#2881 is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the Bug
Following the next release of Sunshine; let's add Sunshine to AppImage hub. AppImage/appimage.github.io#2881
Expected Behavior
No response
Additional Context
This will require that the
sunshine.AppImage
be distributed as a single file instead of an archive. See here: AppImage/appimage.github.io#2881 (comment)Initially ran into issues attempting to do this with the paths, potentially code changes will be required in sunshine, see here: linuxdeploy/linuxdeploy#201
AppImage suggests that the binary needs to find files relative to itself, which I don't believe is the case, and probably part of the problem. See here: https://docs.appimage.org/packaging-guide/from-source/native-binaries.html?highlight=relative%20path#packaging-existing-binaries-or-manually-packaging-everything
A possible solution is to create a custom
AppRun
file that takes care of copying files out of the AppImage to the expected locations. I'm thinking this could also setup the udev rules. The AppRun can be any type of executable or even a symlink. I'm thinking a bash script would make the most sense.Another potential solution is to use pkg2AppImage which can patch the sunshine binary, I don't know if it will work in our case. See here: https://docs.appimage.org/packaging-guide/converting-binary-packages/pkg2appimage.html?highlight=apprun#keys-that-enable-ability-to-relocate
Sunshine Host Operating System and Version
Linux
Architecture
Sunshine Version
GPU Type
GPU Model
GPU Driver/Mesa Version
Capture Method (Linux Only)
The text was updated successfully, but these errors were encountered: