Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sunshine to appimage.github.io #151

Closed
ReenigneArcher opened this issue May 6, 2022 · 2 comments
Closed

Add Sunshine to appimage.github.io #151

ReenigneArcher opened this issue May 6, 2022 · 2 comments
Assignees

Comments

@ReenigneArcher
Copy link
Member

ReenigneArcher commented May 6, 2022

Describe the Bug

Following the next release of Sunshine; let's add Sunshine to AppImage hub. AppImage/appimage.github.io#2881

Expected Behavior

No response

Additional Context

This will require that the sunshine.AppImage be distributed as a single file instead of an archive. See here: AppImage/appimage.github.io#2881 (comment)

Initially ran into issues attempting to do this with the paths, potentially code changes will be required in sunshine, see here: linuxdeploy/linuxdeploy#201

AppImage suggests that the binary needs to find files relative to itself, which I don't believe is the case, and probably part of the problem. See here: https://docs.appimage.org/packaging-guide/from-source/native-binaries.html?highlight=relative%20path#packaging-existing-binaries-or-manually-packaging-everything

A possible solution is to create a custom AppRun file that takes care of copying files out of the AppImage to the expected locations. I'm thinking this could also setup the udev rules. The AppRun can be any type of executable or even a symlink. I'm thinking a bash script would make the most sense.

Another potential solution is to use pkg2AppImage which can patch the sunshine binary, I don't know if it will work in our case. See here: https://docs.appimage.org/packaging-guide/converting-binary-packages/pkg2appimage.html?highlight=apprun#keys-that-enable-ability-to-relocate

Sunshine Host Operating System and Version

Linux

Architecture

Sunshine Version

GPU Type

GPU Model

GPU Driver/Mesa Version

Capture Method (Linux Only)

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

This issue is stale because it has been open for 30 days with no activity. Remove the stale label or comment, otherwise this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jun 6, 2022
@ReenigneArcher ReenigneArcher mentioned this issue Jun 9, 2022
5 tasks
@ReenigneArcher ReenigneArcher removed their assignment Jul 1, 2022
@ReenigneArcher ReenigneArcher added the help wanted Extra attention is needed label Jul 1, 2022
@ReenigneArcher ReenigneArcher mentioned this issue Aug 17, 2022
7 tasks
@ReenigneArcher ReenigneArcher mentioned this issue Sep 12, 2022
5 tasks
@ReenigneArcher ReenigneArcher removed the help wanted Extra attention is needed label Oct 5, 2022
@ReenigneArcher ReenigneArcher changed the title Add Sunshine to AppImage hub Add Sunshine to appimage.github.io Nov 2, 2022
@ReenigneArcher
Copy link
Member Author

AppImage/appimage.github.io#2881 is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants