Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full coverage of options in sunshine.conf #45

Closed
KuleRucket opened this issue Feb 9, 2022 · 1 comment · Fixed by #49
Closed

Full coverage of options in sunshine.conf #45

KuleRucket opened this issue Feb 9, 2022 · 1 comment · Fixed by #49
Assignees
@ReenigneArcher
Labels
documentation Improvements or additions to documentation fixed This issue has been fixed and will be available in the next release.

Comments

@KuleRucket
Copy link
Contributor

Describe the bug
The sample sunshine.conf does not contain amd_quality and key_rightalt_to_key_win which are allowed by config.cpp so these settings are effectively undocumented.

To Reproduce
grep for "vars" in config.cpp to see what's allowed.

Expected behavior
sample sunshine.conf should document all options

Screenshots
n/a

Host
n/a

Additional context
n/a
@ReenigneArcher ReenigneArcher mentioned this issue Feb 10, 2022
Merged
5 tasks
@ReenigneArcher ReenigneArcher self-assigned this Feb 10, 2022
@ReenigneArcher ReenigneArcher added documentation Improvements or additions to documentation fixed This issue has been fixed and will be available in the next release. labels Feb 10, 2022
@github-actions
Copy link

This issue has been fixed and will be available in the next release.

@ReenigneArcher ReenigneArcher linked a pull request Feb 12, 2022 that will close this issue
Fix sample config #49
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReenigneArcher ReenigneArcher

Labels
documentation Improvements or additions to documentation fixed This issue has been fixed and will be available in the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sample config LizardByte/Sunshine
2 participants
@KuleRucket @ReenigneArcher