Jelle refactored api v2 new user view #73
Conversation
|
Changes Unknown when pulling 0d3cd23 on jelle_refactored_api_v2_new_user_view into ** on master**. |
There was a problem hiding this comment.
1 opmerking over een log message, verder ziet het er prima uit.
Mooi om te zien dat het door die 409 ook gewoon duidelijker en netter wordt!
Wel met @byrman even kijken of lizard er netjes mee om gaat ("eerst zoeken, daarna pas aanmaken").
| '/sso/local_login/', | ||
| message) | ||
| # Hardcode the test time value for both URLSafeTimedSerializers | ||
| hardcoded_time_value = 1511775523 |
There was a problem hiding this comment.
Goeie! Dit gaf inderdaad sporadisch test foutjes...
lizard_auth_server/views_api_v2.py
Outdated
| if len(matching_users) > 1: | ||
| logger.debug( | ||
| "More than one user found for '%s', returning the first", | ||
| form.cleaned_data['email']) | ||
| user = matching_users[0] | ||
| logger.info("Found existing user %s, giving that one to %s", | ||
| logger.info("Found existing user based on email %s in portal: %s", |
There was a problem hiding this comment.
Een user zit niet echt in een portal. Ik zou "in portal %s" gewoon weghalen, dan is het ook goed.
|
Die jenkins foutjes komen hierdoor: buildout/buildout#425 |
|
Changes Unknown when pulling 7cf31db on jelle_refactored_api_v2_new_user_view into ** on master**. |
|
Changes Unknown when pulling 2c187a7 on jelle_refactored_api_v2_new_user_view into ** on master**. |
|
@reinout: Uitgebreidere beschrijving in CHANGES.rst toegevoegd. |
username/email in gebruik geeft beide een 409 conflict statuscode.
Het 'time mocken' zou dit moeten oplossen:
FAIL: test_login_redirect (lizard_auth_server.tests.test_views_sso.TestLoginRedirect)
Traceback (most recent call last):
File "/home/travis/build/lizardsystem/lizard-auth-server/lizard_auth_server/tests/test_views_sso.py", line 147, in test_login_redirect
self.portal.redirect_url)
File "/home/travis/build/lizardsystem/lizard-auth-server/lizard_auth_server/tests/test_views_sso.py", line 117, in authorize_and_check_redirect
_strip_after_last_dot(expec))
AssertionError: 'http[43 chars]age=.eJyrVipKLSxNLS6JL8nPTs1TskLj6ygllpZkwCWROLUAnvEWHw.DPV9gg' != 'http[43 chars]age=.eJyrVipKLSxNLS6JL8nPTs1TskLj6ygllpZkwCWROLUAnvEWHw.DPV9gw'
? ^