Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel build fixes #122

Merged
merged 2 commits into from Mar 18, 2016
Merged

Kernel build fixes #122

merged 2 commits into from Mar 18, 2016

Conversation

bw35
Copy link
Contributor

@bw35 bw35 commented Mar 13, 2016

Building the kernel from the linux_media repository w/o media_build requires some small modifications to the saa716x Kconfig and Makefile.

When MEDIA_SUBDRV_AUTOSELECT is set, the required frontend and tuner
drivers are automatically selected for building.

Signed-off-by: Peter Horn <peter.horn@bluewin.ch>
The include path to the tuner header files was missing from the Makefile,
therefore the build failed with a compiler error.


Signed-off-by: Peter Horn <peter.horn@bluewin.ch>
ljalves added a commit that referenced this pull request Mar 18, 2016
@ljalves ljalves merged commit 11d8d01 into ljalves:latest Mar 18, 2016
@tkurbad
Copy link
Contributor

tkurbad commented Apr 6, 2016

@bw35 These changes prevent the saa716x_budget module from being build w/ media_build.
How can this be overcome? Has media_build to be changed somehow?

@bw35
Copy link
Contributor Author

bw35 commented Apr 7, 2016

@tkurbad In fact I didn't try with media_build. I've cross compiled the kernel in this repo. I'll try with media_build to see where it fails.

Maybe you have more info for me: For which kernel version did you try to build the drivers and what was the relevant output of the build process?

@tkurbad
Copy link
Contributor

tkurbad commented Apr 7, 2016

I tried to compile for kernel version 4.5.0. There weren't any build errors. Only after installing I noticed that the saa716x_budget module was missing (saa716x_core, saa716x_ff, and saa716x_hybrid were there, nonetheless)

I then checked out c9626a9 and reran the build. Now the missing module is there again (and works).

HTH,
Torsten

@bw35
Copy link
Contributor Author

bw35 commented Apr 12, 2016

@tkurbad
I can't reproduce your problem. I've done the media_build method as described in the wiki and got all modules including saa716x_budget.ko in the media_build/v4l directory. Checked with Kernel 4.1.15 and 4.5.0, latter required a small fix in the cdx2820r_core.c because of a change introduced by kernel 4.5 in include/linux/gpio/driver.

@tkurbad
Copy link
Contributor

tkurbad commented Apr 13, 2016

@bw35
Strange. I'll look into it again after my next kernel update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants