Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for Python 2.7/3.4+ #15

Merged
merged 7 commits into from
Mar 11, 2018
Merged

Updates for Python 2.7/3.4+ #15

merged 7 commits into from
Mar 11, 2018

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Mar 9, 2018

Changes proposed in this pull request:

  • Don't test AppVeyor on Python 3.3
  • Add python_requires to help pip
  • Simplify some version checks
  • Remove unused imports and variables
  • Rewrite some unnecessary literals and generators, now possible with Python 2.7/3.4+

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4c193a9 on hugovk:update-versions into 434f55c on ljcooke:develop.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4c193a9 on hugovk:update-versions into 434f55c on ljcooke:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4c193a9 on hugovk:update-versions into 434f55c on ljcooke:develop.

@coveralls
Copy link

coveralls commented Mar 9, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4c193a9 on hugovk:update-versions into 434f55c on ljcooke:develop.

@ljcooke ljcooke self-requested a review March 9, 2018 22:24
@ljcooke ljcooke self-assigned this Mar 9, 2018
ljcooke
ljcooke approved these changes Mar 11, 2018
View reviewed changes
Copy link
Owner

@ljcooke ljcooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good stuff, thanks!

@ljcooke ljcooke merged commit 0a83016 into ljcooke:develop Mar 11, 2018
@hugovk hugovk deleted the update-versions branch March 11, 2018 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljcooke ljcooke ljcooke approved these changes

Assignees

@ljcooke ljcooke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hugovk @coveralls @ljcooke