add is_supercombinator to Term #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
requested changes
Dec 14, 2017
src/term.rs
Outdated
| /// ``` | ||
| /// use lambda_calculus::term::*; | ||
| /// | ||
| /// let term1 = abs(app(Var(1), abs(Var(1)))); // λ 1 (λ 2) |
There was a problem hiding this comment.
the comment has an error - it should be λ 1 (λ 1)
src/term.rs
Outdated
| @@ -288,6 +288,36 @@ impl Term { | |||
| pub fn rhs_mut(&mut self) -> Result<&mut Term, TermError> { | |||
| if let Ok((_, rhs)) = self.unapp_mut() { Ok(rhs) } else { Err(NotApp) } | |||
| } | |||
|
|
|||
| /// Returns `true` if and only if the lambda term is a | |||
There was a problem hiding this comment.
nitpicking: I'd drop "and only if"
src/term.rs
Outdated
| let mut stack = Vec::new(); | ||
| stack.push((0, self)); | ||
| while let Some((depth, term)) = stack.pop() { | ||
| match term { |
src/term.rs
Outdated
| /// ``` | ||
| pub fn is_supercombinator(&self) -> bool { | ||
| let mut stack = Vec::new(); | ||
| stack.push((0, self)); |
There was a problem hiding this comment.
it will probably never be an issue in practice, but 0 is inferred as i32 here; it would be a good idea to annotate it as 0usize
ljedrz
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unrelated to 2.0.0 API changes, I think this is useful.
I wrote a naive recursive implementation for comparison; this naive iterative version is about 2x faster. Not sure if it's worth adding a warning to the documentation indicating that this function has to traverse the entire
Term.