Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToNumber environment issues. #2

Closed
Xotic750 opened this issue Nov 1, 2015 · 1 comment
Closed

ToNumber environment issues. #2

Xotic750 opened this issue Nov 1, 2015 · 1 comment

Comments

@Xotic750
Copy link

Xotic750 commented Nov 1, 2015

Several tests have highlighted issues regarding ToNumber conversion. I don't have time to create specific tests here just now, but they are being dealt with in es6-shim.

paulmillr/es6-shim#366

Original identification was in lodash

Original PR lodash/lodash#1577
Actual merge lodash/lodash@3795534
@ljharb ljharb changed the title ToNumber envrionment issues. ToNumber environment issues. Nov 1, 2015
@ljharb ljharb closed this as completed in de532ba Nov 1, 2015
ljharb added a commit that referenced this issue Nov 1, 2015
@ljharb
[Fix] ensure only 0-1 are valid binary and 0-7 are valid octal digits.
51742da 
Fixes #2.
@Xotic750
Copy link
Author

Xotic750 commented Nov 2, 2015

I believe there is still the issue of bad hex strings +/-HEX paulmillr/es6-shim#366 paulmillr/es6-shim#369

@Xotic750 Xotic750 mentioned this issue Nov 4, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Xotic750