Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data files in operations folder are missing from v1.14 onwards #62

Closed
ExE-Boss opened this issue Oct 24, 2019 · 5 comments
Closed

Data files in operations folder are missing from v1.14 onwards #62

ExE-Boss opened this issue Oct 24, 2019 · 5 comments

Comments

@ExE-Boss
Copy link
Contributor

This is a breaking change, since everything reachable is part of the public API.

I recommend keeping the 2015.js, 2016.js, 2017.js, 2018.js and 2019.js files, which export useful data.
@ExE-Boss ExE-Boss changed the title operations folder is missing from v1.14 Data files in operations folder are missing from v1.14 onwards Oct 24, 2019
@ljharb
Copy link
Owner

ljharb commented Oct 24, 2019

That is true; the data was only intended for use by tests.

Other than your types PR, are you aware of anyone using the data? I’d prefer to consider it a bug that they were ever included, and I’d sooner bump to v2 than re-include them.

@ljharb
Copy link
Owner

ljharb commented Nov 3, 2019

Closing, pending more info.

@ljharb ljharb closed this as completed Nov 3, 2019
@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Nov 6, 2019

Well, since you want to bump to v2 anyway, you should include the breaking changes from #67 and #68 with it.

This was referenced Nov 7, 2019
Merged
Open
@ljharb
Copy link
Owner

ljharb commented Nov 8, 2019

hmm, I'm actually confused. I npmignored the js files in operations/, not the json files. Those should be included still.

@ljharb ljharb reopened this Nov 8, 2019
@ljharb
Copy link
Owner

ljharb commented Nov 8, 2019

ah lol they're all JS files. I think I intended to only block the scripts, not the data.

@ljharb ljharb closed this as completed in 020dd1b Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljharb @ExE-Boss