[Breaking] 2018/2019: GetIterator: Add hint parameter
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This is backwards incompatible, as the `hint` parameter is added between the `obj` and `method` parameters.
ExE-Boss
commented
Nov 4, 2019
es2018.js
Outdated
Comment on lines
192
to
200
| // TODO: This should return an IteratorRecord | ||
| /* | ||
| var nextMethod = this.GetV(iterator, 'next'); | ||
| return { | ||
| '[[Iterator]]': iterator, | ||
| '[[NextMethod]]': nextMethod, | ||
| '[[Done]]': false | ||
| }; | ||
| */ |
There was a problem hiding this comment.
This is also a breaking change, which should probably be made as part of the v2.0 release, which should be where this gets first released.
There was a problem hiding this comment.
I’m doing this in #68.
This was referenced Nov 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 90.82% 90.29% -0.53%
==========================================
Files 828 828
Lines 11541 11567 +26
Branches 2652 2662 +10
==========================================
- Hits 10482 10445 -37
- Misses 1059 1122 +63
Continue to review full report at Codecov.
|
ExE-Boss
force-pushed
the
feat/es2018/get-iterator
branch
from
5cef84b
to
8f49af3
Compare
ljharb
force-pushed
the
feat/es2018/get-iterator
branch
from
8f49af3
to
224dd6d
Compare
ExE-Boss
force-pushed
the
feat/es2018/get-iterator
branch
from
224dd6d
to
1971333
Compare
ExE-Boss
changed the title
hint parameter to GetIterator2018+: GetIterator: Add hint parameter
|
@ljharb I’ve rebased this, but some builds didn’t run due to GitHub rate‑limiting Travis CI. |
ExE-Boss
force-pushed
the
feat/es2018/get-iterator
branch
from
1971333
to
0e54952
Compare
ljharb
added a commit
that referenced
this pull request
Oct 1, 2020
See #67 Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
ljharb
force-pushed
the
feat/es2018/get-iterator
branch
from
0e54952
to
b967be4
Compare
|
I've pulled these changes into ES2020 in ddbba60, and rebased this PR, so now it's only breaking for ES2018 and ES2019 - and ES2020+ will have the proper signature, and adding async iterator support will be semver-minor. |
ljharb
changed the title
2018+: GetIterator: Add hint parameter2018/2019: GetIterator: Add hint parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #66.
BREAKING CHANGE: This is backwards incompatible, as the
hintparameter is added between theobjandmethodparameters.review?(@ljharb)