Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] migrate OSX tests to GHA #37

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

aks-
Copy link

@aks- aks- commented Mar 14, 2024

I will create a separate PR to ubuntu in the matrix. Currently I am using nvm to install latest nvm for given node version. How can I achieve the same with your custom GitHub action. Is there any documentation you can point me to?

Co-authored-by: Ashok Suthar <coderatlabs@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@aks- aks- force-pushed the migrate-travis-to-ghub-action branch from f25e3aa to 763b968 Compare March 14, 2024 09:06
Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this by adding mac OS to the existing matrix, if possible, instead of duplicating the workflow.

@aks- aks- force-pushed the migrate-travis-to-ghub-action branch from 763b968 to d7c5fb9 Compare March 22, 2024 09:22
@ljharb ljharb self-requested a review March 23, 2024 16:54
@ljharb ljharb force-pushed the migrate-travis-to-ghub-action branch from d7c5fb9 to e522dcc Compare March 23, 2024 19:47
@ljharb ljharb changed the title [github-action]: migrate test-only from travis to actions [actions] migrate OSX tests to GHA Mar 23, 2024
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.50%. Comparing base (fa60e3d) to head (38f8d25).

❗ Current head 38f8d25 differs from pull request most recent head 5508b6c. Consider uploading reports for the commit 5508b6c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   76.07%   76.50%   +0.42%     
==========================================
  Files          77       77              
  Lines        3800     3800              
  Branches     1257     1257              
==========================================
+ Hits         2891     2907      +16     
+ Misses        909      893      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb force-pushed the migrate-travis-to-ghub-action branch from 05ea042 to 69128ed Compare March 24, 2024 05:40
Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took care of it, will merge after tests pass.

@ljharb ljharb force-pushed the migrate-travis-to-ghub-action branch 2 times, most recently from 38f8d25 to 5508b6c Compare March 24, 2024 07:05
@ljharb ljharb merged commit 5508b6c into ljharb:main Mar 24, 2024
861 of 867 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants