[Fix] assert: throw on a nonexistent slot even when an object alrea…

…dy has other slots
ljharb · Dec 13, 2022 · 12580bd · 12580bd
1 parent 227e81e
commit 12580bd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -15,6 +15,9 @@ var SLOT = {
 			throw new $TypeError('`slot` must be a string');
 		}
 		channel.assert(O);
+		if (!SLOT.has(O, slot)) {
+			throw new $TypeError('`slot` is not present on `O`');
+		}
 	},
 	get: function (O, slot) {
 		if (!O || (typeof O !== 'object' && typeof O !== 'function')) {

diff --git a/test/index.js b/test/index.js
@@ -32,6 +32,7 @@ test('assert', function (t) {
 	var o = {};
 	SLOT.set(o, 'x');
 	t.doesNotThrow(function () { SLOT.assert(o, 'x'); }, 'existent slot noops');
+	t['throws'](function () { SLOT.assert(o, 'y'); }, 'thing with a slot throws on a nonexistent slot');
 
 	t.end();
 });